kw2542 opened a new pull request #1291: SAMZA-2471: Simplify CommandLine URL: https://github.com/apache/samza/pull/1291 Design: https://cwiki.apache.org/confluence/display/SAMZA/SEP-23%3A+Simplify+Job+Runner Changes: 1. Simplify CommandLine by removing unnecessary arguments. API Changes: 1. config-loader-factory removed in CommandLine 2. config-loader-properties removed in CommandLine Upgrade Instruction: 1. Usage of --config-factory and --config-loader-factory will be switched to --config job.config.loader.factory 2. Usage of --config-path and --config-loader-properties will be switched to --config job.config.loader.properties Usage Instruction --config-factory=org.apache.samza.config.factories.PropertiesConfigFactory --config-path=file:///location/file.txt and --config-loader-factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory --config-loader-properties path=file:///location/file.txt will be updated to --config job.config.loader.factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory --config job.config.loader.properties.path=file:///location/file.txt Tests 1. Unit tests 2. Test against Hello Samza example with deploy/samza/bin/run-app.sh --config job.config.loader.factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory --config job.loader.properties.path=$PWD/deploy/samza/config/wikipedia-feed.properties
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
