rmatharu commented on a change in pull request #1297: SAMZA-2379: Support
Container Placements for job running in degraded state
URL: https://github.com/apache/samza/pull/1297#discussion_r387925995
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java
##########
@@ -110,7 +110,17 @@
*/
public final ConcurrentMap<String, SamzaResource> runningProcessors = new
ConcurrentHashMap<>(0);
- /**
+ /**
+ * Map of the failed Samza processor ID to resource status of the last
attempted of the container.
+ * This map is only used when {@link
org.apache.samza.config.ClusterManagerConfig#CLUSTER_MANAGER_CONTAINER_FAIL_JOB_AFTER_RETRIES}
+ * is set to false, this map tracks the containers which have exhausted all
retires for restart and JobCoordinator is
+ * no longer attempting to restart this container
+ *
+ * Modified by both the AMRMCallbackThread and the ContainerAllocator thread
+ */
+ public final ConcurrentHashMap<String, SamzaResourceStatus> failedProcessors
= new ConcurrentHashMap<>(0);
Review comment:
This class already has a map called
```
/**
* ContainerStatuses of failed containers. * ContainerStatuses of
failed containers.
*/
public final ConcurrentMap<String, SamzaResourceStatus>
failedContainersStatus = new ConcurrentHashMap<>();
```
Could we please reuse that?
Also the variable type can just be a Map<,> doesnt need to be
ConcurrentHashMap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
