mynameborat commented on issue #1301: New kv metric URL: https://github.com/apache/samza/pull/1301#issuecomment-595465111 > a. Take a look at https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines > and update the description so that other reviewers can easily review the change. > > b. there are some test failures, maybe worth looking at them. +1 Can you update the PR title to include JIRA and follow the guidelines? Looks like your test file doesn't have the apache file and fails rat. Make sure you add the apache license for the new files.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
