rmatharu commented on a change in pull request #1297: SAMZA-2379: Support
Container Placements for job running in degraded state
URL: https://github.com/apache/samza/pull/1297#discussion_r389048888
##########
File path:
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerPlacementActions.java
##########
@@ -528,6 +528,124 @@ public Void answer(InvocationOnMock invocation) {
assertFalse(containerPlacementMetadataStore.readContainerPlacementRequestMessage(requestMessage.getUuid()).isPresent());
}
+
+ @Test(timeout = 20000)
Review comment:
This test is littered with thread.sleep and timeouts -- a typical recipe for
flaky jarvis/test, and increasing build times.
Would it be possible to reduce/consolidate them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
