bkonold edited a comment on issue #1305: SAMZA-2479: Add configurable default for min compaction lag ms URL: https://github.com/apache/samza/pull/1305#issuecomment-597286149 > Few questions > > 1. What do you think about having this configuration under `JobConfig` hierarchy instead of `StoreConfig`? I see why it is the way it is in your current PR and the reason for it to belong under `StoreConfig`. However, `stores.default....` dilutes the (implicit) stronger contract of what follows `stores` is the store name and makes `default` as a reserved store name. > 2. What are the challenges in coming up with code default for it? Can you add details in PR description about the limitations of code default and the need for configurability? @mynameborat 1. I think that if the intention behind the various Config classes is to divide things semantically rather than by namespace, this is a good suggestion since this config will, if set, apply to all changelogs within the job. Is there any problem on StorageConfig depending on JobConfig? I will need to instantiate JobConfig to access to job-wide default to enforce the correct precedence. 2. Will respond here and add to the PR. The need for a different value comes from an evaluation done internally (within LI) that we can have a more relaxed setting than 4hr across all our jobs. The code default was chosen when the feature was implemented and is now part of a released build of samza; this 4hr value has been communicated to OSS customers and since changing this value has an operational impact on customers' kafka deployments (storage space) and each customer may have different thresholds for what is acceptable in terms of cost, making this default configurable empowers them to easily configure their samza/kafka clusters.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
