Zhangyx39 opened a new pull request #1320: SAMZA-2490: 
AsyncFlatmapOperatorImpl#handleClose should call transformFn.close()
URL: https://github.com/apache/samza/pull/1320
 
 
   Symptom: In beam samza runner, Op#close is not invoked during shutdown, 
which is not expected.
   
   Cause: AsyncFlatmapOperatorImpl#handleClose() doesn't call 
transformFn.close(). Therefore the underlying transform function will never be 
closed.
   
   Changes: Just invoke transformFn.close inside handleClose method should be 
enough.
   
   Tests: Tested with a samza beam job. After the change, Op#close is able to 
function properly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to