PanTheMan opened a new pull request #1329: Remove TestSuiteAnnotation from 
TestBatchProcessor
URL: https://github.com/apache/samza/pull/1329
 
 
   Note - This seemed trivial enough to not create a ticket, but let me know if 
there should be a ticket
   Symptoms: Currently in Linkedin internal, when building Samza with the 
latest open source changes on Mac, TestBatchProcessor tests keep failing.
   Causes: Currently this TestSuiteAnnotation used in TestBatchProcessor is 
causing the tests to be ran twice when building using gradle (documented inĀ 
gradle/gradle#5484). This seems to be causing issues internally where because 
we cap the memory used for testing to 1.5gb (in a recent commit) currently, 
leads to this test failing. The current theory is that Mac seems to be using 
more memory as building on Linux passes.
   Fix: By removing the TestSuiteAnnotation, these tests are only ran once and 
leads to the build passing. As it seems like running these tests twice are 
redundant, we can remove the annotation.
   Tests: Try to build samza internally with the latest open source changes 
(git merge master HEAD) and this test will fail on Mac.
   I've verified that removing this annotation still leads to these tests being 
ran but only once and the TestSuite doesn't seem to be used anywhere in Samza.
   Ran ./gradlew clean build test to verify building still works.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to