mynameborat commented on a change in pull request #1337: SAMZA-2498: [Job
coordinator isolation] Classloader isolation for SamzaApplication.describe
execution in job coordinator
URL: https://github.com/apache/samza/pull/1337#discussion_r401398714
##########
File path:
samza-core/src/main/java/org/apache/samza/application/ApplicationUtil.java
##########
@@ -32,17 +34,37 @@
public class ApplicationUtil {
/**
- * Creates the {@link SamzaApplication} object from the task or application
class name specified in {@code config}
+ * Creates the {@link SamzaApplication} object from the task or application
class name specified in {@code config}.
+ *
+ * This will use the current classloader to load the {@link
SamzaApplication}.
*
* @param config the configuration of the application
* @return the {@link SamzaApplication} object
*/
public static SamzaApplication fromConfig(Config config) {
+ return fromConfig(config, false);
+ }
+
+ /**
+ * Creates the {@link SamzaApplication} object from the task or application
class name specified in {@code config}.
+ * If {@code canApplyFrameworkIsolationIfEnabled} is true and isolation is
enabled (in the config), then this will
+ * build the {@link SamzaApplication} using a special isolating classloader.
Otherwise, this will use the current
Review comment:
why do we need two levels (this boolean & the config) to determine the
behavior? Can we not infer from the config and then use the appropriate loader?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
