alnzng commented on a change in pull request #1342: SAMZA-2509: New config name
to represent if split deployment feature is enabled
URL: https://github.com/apache/samza/pull/1342#discussion_r406867774
##########
File path:
samza-core/src/main/java/org/apache/samza/config/ShellCommandConfig.java
##########
@@ -58,16 +58,14 @@
public static final String ENV_EXECUTION_ENV_CONTAINER_ID =
"EXECUTION_ENV_CONTAINER_ID";
/**
- * Set to "true" if cluster-based job coordinator dependency isolation is
enabled. Otherwise, will be considered
- * false.
+ * Set to "true" if split deployment feature is enabled. Otherwise, will be
considered false.
*
- * The launch process for the cluster-based job coordinator depends on the
value of this, since it needs to be known
- * if the cluster-based job coordinator should be launched in an isolated
mode. This needs to be an environment
- * variable, because the value needs to be known before the full configs can
be read from the metadata store (full
- * configs are only read after launch is complete).
+ * The launch process for the cluster-based job coordinator and job
container depends on the value of this, since it
+ * needs to be known if the cluster-based job coordinator and job container
should be launched in an isolated mode.
Review comment:
sure, thanks for pointing out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
