cameronlee314 opened a new pull request #1350: URL: https://github.com/apache/samza/pull/1350
Feature: https://cwiki.apache.org/confluence/display/SAMZA/SEP-24%3A+Cluster-based+Job+Coordinator+Dependency+Isolation#SEP-24:Cluster-basedJobCoordinatorDependencyIsolation-HandlingSamzaApplication.describe Changes: Add a new `samza-framework-descriptors-classes.txt` whitelist which will be the list of descriptors (including table functions) that are considered part of the framework, which apps may use to in their implementation of `SamzaApplication.describe`. Testing: 1. Deployed `wikipedia-feed` application with isolation enabled and verified (using logs) that the correct classloaders were used to load the descriptors (the app uses a Kafka descriptor and a custom descriptor). 2. Modified `wikipedia-feed` to use a table descriptor and a fake table function which was included as part of the framework descriptors. Verified (using logs) that the correct classloaders loaded the table components in the job coordinator. Note that further testing is going to be needed when using this new flow on the processing containers. We will need to ensure that the infrastructure classloader can use the descriptors properly when executing processing logic. API/usage changes: 1. No change for applications. 2. When preparing the tarball for the framework API, an additional `samza-framework-descriptors-classes.txt` needs to be included, and it needs to include the classes (or globs) for the descriptors that are considered part of the framework. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
