lakshmi-manasa-g opened a new pull request #1362:
URL: https://github.com/apache/samza/pull/1362


   **Bug fix**
   **Symptom:** No visible symptoms seen yet. Potential symptom is invalid 
blobs created.
   
   **Cause:** When Avro's DataFileWriter.close fails, blob is committed with 
uploaded blocks which means the sync marker flushed by DataFileWriter.close is 
absent potentially causing invalid blobs.
   
   **Changes:** No commit of blob if DataFileWriter.close fails. This means 
uploaded blocks are discarded in this scenario and user of the SystemProducer 
should catch this exception and retry to avoid data loss.
   
   **API changes:** Behavior change: Blob not committed if DataFileWriter.close 
fails discarding all uploaded blocks.
   
   **Upgrade Instructions:** Catch exceptions arising out of 
AzureBlobSystemProducer.flush and retry messages since previous flush. Do not 
advance checkpoint if flush fails.
   
   **Usage Instructions:** None
   
   **Tests:** unit test updated.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to