lakshmi-manasa-g commented on a change in pull request #1364:
URL: https://github.com/apache/samza/pull/1364#discussion_r427783902



##########
File path: 
samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobOutputStream.java
##########
@@ -85,6 +85,7 @@
 
   private volatile boolean isClosed = false;
   private long totalUploadedBlockSize = 0;
+  private long totalNumberOfRecordsInBlob = 0;

Review comment:
       AtomicLong is a nice thing to do. However, the methods of this class are 
all synchronized as there are other aspects beyond this variable that require 
single threaded access. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to