mynameborat commented on a change in pull request #1366: URL: https://github.com/apache/samza/pull/1366#discussion_r430537718
########## File path: samza-core/src/main/java/org/apache/samza/container/RunLoopTask.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.container; + +import java.util.Collections; +import org.apache.samza.checkpoint.OffsetManager; +import org.apache.samza.scheduler.EpochTimeScheduler; +import org.apache.samza.system.IncomingMessageEnvelope; +import org.apache.samza.system.SystemStreamPartition; +import org.apache.samza.task.ReadableCoordinator; +import org.apache.samza.task.TaskCallbackFactory; +import scala.collection.JavaConversions; + + +public interface RunLoopTask { Review comment: Let us take this opportunity to document more details about runloop and its interaction with the implementations of this interface. 1. Exclusivity between process, window, scheduler, commit. & endOfStream with the exception of async commit. 2. Not thread safe and needs synchronization of shared objects between instances, between commit & other methods in case of async commit enabled within an instance 3. Lifecycle of this class if applicable; which brings a question on does this need `init()` and `close()`; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
