bkonold commented on a change in pull request #1367: URL: https://github.com/apache/samza/pull/1367#discussion_r430878347
########## File path: samza-core/src/main/java/org/apache/samza/storage/TaskSideInputHandler.java ########## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.storage; + + +import com.google.common.annotations.VisibleForTesting; +import java.io.File; +import java.util.AbstractMap; +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.stream.Collectors; +import org.apache.samza.Partition; +import org.apache.samza.SamzaException; +import org.apache.samza.container.TaskName; +import org.apache.samza.job.model.TaskMode; +import org.apache.samza.storage.kv.Entry; +import org.apache.samza.storage.kv.KeyValueStore; +import org.apache.samza.system.IncomingMessageEnvelope; +import org.apache.samza.system.StreamMetadataCache; +import org.apache.samza.system.SystemAdmins; +import org.apache.samza.system.SystemStream; +import org.apache.samza.system.SystemStreamMetadata; +import org.apache.samza.system.SystemStreamPartition; +import org.apache.samza.util.Clock; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import scala.collection.JavaConverters; + + +/** + * This class encapsulates all processing logic / state for all side input SSPs within a task. + */ +public class TaskSideInputHandler { + private static final Logger LOG = LoggerFactory.getLogger(TaskSideInputHandler.class); + + private final StorageManagerUtil storageManagerUtil = new StorageManagerUtil(); + + private final TaskName taskName; + private final TaskSideInputStorageManager taskSideInputStorageManager; + private final Map<SystemStreamPartition, Set<String>> sspToStores; + private final Map<String, SideInputsProcessor> storeToProcessor; + private final SystemAdmins systemAdmins; + private final StreamMetadataCache streamMetadataCache; + private final Map<SystemStreamPartition, String> lastProcessedOffsets = new ConcurrentHashMap<>(); + + private Map<SystemStreamPartition, String> startingOffsets; + + public TaskSideInputHandler( + TaskName taskName, + TaskMode taskMode, + File storeBaseDir, + Map<String, StorageEngine> storeToStorageEngines, + Map<String, Set<SystemStreamPartition>> storeToSSPs, + Map<String, SideInputsProcessor> storeToProcessor, + SystemAdmins systemAdmins, + StreamMetadataCache streamMetadataCache, + Clock clock) { + this.taskName = taskName; + this.systemAdmins = systemAdmins; + this.streamMetadataCache = streamMetadataCache; + this.storeToProcessor = storeToProcessor; + + this.sspToStores = storeToSSPs.entrySet().stream() + .flatMap(storeAndSSPs -> storeAndSSPs.getValue().stream() + .map(ssp -> new AbstractMap.SimpleImmutableEntry<>(ssp, storeAndSSPs.getKey()))) + .collect(Collectors.groupingBy( + Map.Entry::getKey, + Collectors.mapping(Map.Entry::getValue, Collectors.toSet()))); + + this.taskSideInputStorageManager = new TaskSideInputStorageManager(taskName, + taskMode, + storeBaseDir, + storeToStorageEngines, + storeToSSPs, + clock); + + validateProcessorConfiguration(); Review comment: This is not actually new - I just moved the bit validating the processor mapping out from the storage manager into the handler. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
