rmatharu commented on a change in pull request #1368:
URL: https://github.com/apache/samza/pull/1368#discussion_r432587309
##########
File path:
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala
##########
@@ -106,9 +106,20 @@ class MetricsSnapshotReporter(
}
}
- def run {
- debug("Begin flushing metrics.")
+ def run() {
Review comment:
Do you think it'd be possible to add a test to test the emission logic
in TestMetricsSnapshotReporter?
Somehow it was overlooked before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
