abhishekshivanna commented on pull request #1369: URL: https://github.com/apache/samza/pull/1369#issuecomment-636527332
> Perhaps adding a test in TestDiagnosticsManager would be prudent? This patch doesn't change the DiagnoticsManager (hence nothing to change in TestDiagnosticsManager ??). Instead, I added a test to verify that the reporter created (using `DiagnosticsUtil#buildDiagnosticsManager`) comes from the factory in configs. Let me know if this looks good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
