bkonold commented on a change in pull request #1382:
URL: https://github.com/apache/samza/pull/1382#discussion_r439650648
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
##########
@@ -82,7 +83,6 @@ class TestKafkaCheckpointManager extends
KafkaServerTestHarness {
val spec = new KafkaStreamSpec("id", checkpointTopic,
checkpointSystemName, 1, 1, props)
val checkPointManager = Mockito.spy(new KafkaCheckpointManager(spec, new
MockSystemFactory, false, config, new NoOpMetricsRegistry))
Review comment:
Do you know why we need to spy the class under test here rather than
mock the underlying objects used by the method that is stubbed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
