mynameborat commented on pull request #1389:
URL: https://github.com/apache/samza/pull/1389#issuecomment-647786767


   > > Do you know of a way to not lose the history with this change? Sadly 
`git annotate` will have this commit all over and make it harder to navigate 
the history.
   > > Not sure if something like this would work for us - 
https://medium.com/@elliotchance/reformatting-your-codebase-with-git-filter-branch-21feded7c423
   > 
   > We aren't quite losing the history. It's just that the most recent commit 
for the file changes. You are right that it will be harder to navigate to find 
the most recent change, but it is still possible to run `git blame` on older 
commits, so the history is still accessible.
   > Thanks for the link, but it looks like the process described in the link 
creates an "all new history" and modifies commit IDs (seems dangerous since it 
could cause issues with forks/branches), and it requires having a tool to 
actually run all of the formatting (and it might be a bit difficult to 
configure a tool to do exactly what we need).
   
   Fair enough, I was skeptical about modifying commit ids & force push too. 
Wanted to check if we could do anything about the navigation part. Looks good 
to me otherwise.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to