b-slim commented on a change in pull request #1384:
URL: https://github.com/apache/samza/pull/1384#discussion_r444317206
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java
##########
@@ -109,15 +124,19 @@ private void registerSourceSchemas(SchemaPlus rootSchema)
{
}
}
- public RelRoot plan(String query) {
+ private Planner getPlanner() {
Review comment:
The planner is a closable resource I think it would be better to use it
within a try block or make sure to close it when done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
