mynameborat commented on pull request #1392: URL: https://github.com/apache/samza/pull/1392#issuecomment-649717035
> yes, that is exactly the case. > the upstream decided to invoke flush on the AzureBlobSystemProducer which inturn invokes flush on all the writers registered with it. The reason for upstream to do so is to commit all the blobs in-flight right now with other writers. 1. Are there other places that might need same handling or is it only the flush method that gets invoked after an uncaught exception? 2. Would be good if we can rely on explicit signal instead of null being the signal for uncaught exception. By having an explicit signal, you can enforce the invariant on flush not getting invoked only in the case of unhandled exception but not in other scenarios where the field got nulled. 3. Can we have a unit test for this scenario? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
