bkonold commented on a change in pull request #1385:
URL: https://github.com/apache/samza/pull/1385#discussion_r456764745
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -110,14 +108,12 @@
public class ContainerStorageManager {
private static final Logger LOG =
LoggerFactory.getLogger(ContainerStorageManager.class);
private static final String RESTORE_THREAD_NAME = "Samza Restore Thread-%d";
- private static final String SIDEINPUTS_READ_THREAD_NAME = "SideInputs Read
Thread";
- private static final String SIDEINPUTS_FLUSH_THREAD_NAME = "SideInputs Flush
Thread";
+ private static final String SIDEINPUTS_THREAD_NAME = "SideInputs Thread";
private static final String SIDEINPUTS_METRICS_PREFIX = "side-inputs-";
// We use a prefix to differentiate the SystemConsumersMetrics for
sideInputs from the ones in SamzaContainer
- private static final int SIDE_INPUT_READ_THREAD_TIMEOUT_SECONDS = 10; //
Timeout with which sideinput read thread checks for exceptions
- private static final Duration SIDE_INPUT_FLUSH_TIMEOUT =
Duration.ofMinutes(1); // Period with which sideinputs are flushed
-
+ private static final int SIDE_INPUT_LATCH_TIMEOUT_SECONDS = 10; // Timeout
with which sideinput thread checks for exceptions
Review comment:
I agree the name can be improved but I don't follow the first part of
your comment. This purpose of this timeout remains the same as it was before
the change: pausing every 10 seconds to check if either the tasks are all
caught up, or if an exception has occurred. The fact that RunLoop is now the
component throwing an exception is irrelevant; it still gets caught the same
way within the thread and dumped into `sideInputException`.
Perhaps just `SIDE_INPUT_CHECK_TIMEOUT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
