Cameron Lee created SAMZA-2565:
----------------------------------
Summary: Add more checkstyle validations to build
Key: SAMZA-2565
URL: https://issues.apache.org/jira/browse/SAMZA-2565
Project: Samza
Issue Type: Improvement
Reporter: Cameron Lee
There could be some benefit in adding some more checkstyle validations to the
Samza build. It might be necessary to update existing code to follow some of
these validations.
Some examples of useful validations could be:
* NeedBraces (requires braces for "if" blocks): A lot of "equals" methods
currently fail this validation though.
* FallThrough (make sure case blocks in switch statements don't fall through
to other case blocks); also consider if the "checkLastCaseGroup" property
should be true or not
* MissingSwitchDefault (make sure switch statements have defaults)
* StringLiteralEquality (don't use "==" with strings)
* AvoidStarImport (do not use wildcard imports): Consider allowing static
imports for Mockito and Assert in tests
* MethodName (make sure naming convention is followed)
* LineLength
* EqualsAvoidNull (avoid NullPointerException when comparing strings)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
