byjiang1996 commented on a change in pull request #1403:
URL: https://github.com/apache/samza/pull/1403#discussion_r463714722
##########
File path:
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java
##########
@@ -34,10 +34,22 @@
/** The number of log messages dropped e.g. because of buffer overflow. Does
not include recursive calls. */
public final Counter logMessagesDropped;
+ /** The size of log messages sent out to SystemProducer. */
+ public final Counter logMessagesBytes;
+
+ /** The number of log messages sent out to SystemProducer. */
+ public final Counter logMessagesCount;
+
+ /** The number of log messages cannot be sent out due to errors e.g.
serialization errors, system producer send errors. */
+ public final Counter logMessagesErrors;
+
public StreamAppenderMetrics(String prefix, MetricsRegistry registry) {
- super(prefix, registry);
+ super(prefix + "-", registry);
bufferFillPct = newGauge("buffer-fill-percent", 0);
recursiveCalls = newCounter("recursive-calls");
logMessagesDropped = newCounter("log-messages-dropped");
+ logMessagesBytes = newCounter("log-messages-bytes");
Review comment:
Sure.
##########
File path:
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java
##########
@@ -34,10 +34,22 @@
/** The number of log messages dropped e.g. because of buffer overflow. Does
not include recursive calls. */
public final Counter logMessagesDropped;
+ /** The size of log messages sent out to SystemProducer. */
+ public final Counter logMessagesBytes;
+
+ /** The number of log messages sent out to SystemProducer. */
+ public final Counter logMessagesCount;
+
+ /** The number of log messages cannot be sent out due to errors e.g.
serialization errors, system producer send errors. */
+ public final Counter logMessagesErrors;
+
public StreamAppenderMetrics(String prefix, MetricsRegistry registry) {
- super(prefix, registry);
+ super(prefix + "-", registry);
bufferFillPct = newGauge("buffer-fill-percent", 0);
recursiveCalls = newCounter("recursive-calls");
logMessagesDropped = newCounter("log-messages-dropped");
+ logMessagesBytes = newCounter("log-messages-bytes");
+ logMessagesCount = newCounter("log-messages-count");
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
