Sanil15 commented on a change in pull request #1417:
URL: https://github.com/apache/samza/pull/1417#discussion_r474341307
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -472,6 +479,9 @@ void
onResourceCompletedWithUnknownStatus(SamzaResourceStatus resourceStatus, St
LOG.info("Container ID: {} for Processor ID: {} failed with exit code:
{}.", containerId, processorId, exitStatus);
Instant now = Instant.now();
state.failedContainers.incrementAndGet();
+ if (state.perProcessorFailureCount.get(processorId) != null) {
+ state.perProcessorFailureCount.get(processorId).incrementAndGet();
+ }
Review comment:
This method is the helper to and is invoked from
onResourceCompleted(...) which does the check for processorId to be legit,
remeber that we also get redundant notifications so we cannot declare a
container orphan / unknown, we need more testing to deem callback senarios as
orphans and that work is beyond the scope of this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
