rmatharu commented on a change in pull request #1421:
URL: https://github.com/apache/samza/pull/1421#discussion_r477013673
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
##########
@@ -80,19 +82,23 @@
private final Optional<StandbyContainerManager> standbyContainerManager;
+ private final LocalityManager localityManager;
Review comment:
+1, using state to fetch locality information was a bad pattern.
Makes writing tests super weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
