weiqingy commented on a change in pull request #1407:
URL: https://github.com/apache/samza/pull/1407#discussion_r485869977



##########
File path: 
samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java
##########
@@ -99,17 +99,6 @@ public SamzaSqlRelMessage convertToRelMessage(KV<Object, 
Object> samzaMessage) {
         new SamzaSqlRelMsgMetadata(0L, 0L));
   }
 
-  /**
-   * Create a SamzaSqlRelMessage for the specified key and Avro record using 
the schema from the Avro record.
-   *
-   */
-  public static SamzaSqlRelMessage convertToRelMessage(Object key, 
IndexedRecord record, Schema schema) {

Review comment:
       although convertToRelMessage is used in samza repo directly, it is 
invoked by others, e.g. BrooklinRelConverter and other xxxRelconverter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to