Sanil15 opened a new pull request #1432: URL: https://github.com/apache/samza/pull/1432
BUG: Currently container placement kill command reports success even then stop container fails because onStreamProcessorStopFailure is not handled by ContainerManager for Container placement kill command only Changes: Kill command for container placements (when destinationHost as "FORCE_RESTART_LAST_SEEN") does not handle callbacks for onStreamProcessorStopFailure that is when a container is failed to be stopped by the underlying cluster manager We handle two cases for kill with this patch - If the container stop is successful, JobCoordinator will report success and container falls back to normal restart path - if the container stop is failed, JobCoordinator will report error and container is left untouced NOTE: this does not apply to other commands only a known issue when kill is issued API Changes: None Tests: Tested the change with a yarn job deploy Upgrade Instructions: None Usage Instructions: None ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
