mynameborat commented on a change in pull request #1439:
URL: https://github.com/apache/samza/pull/1439#discussion_r524699993
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/CoordinationConstants.java
##########
@@ -27,4 +27,7 @@ private CoordinationConstants() {}
public static final String APPLICATION_RUNNER_PATH_SUFFIX =
"ApplicationRunnerData";
public static final String RUNID_LOCK_ID = "runId";
public static final int LOCK_TIMEOUT_MS = 300000;
+ public static final String CLUSTERBASED_CONTAINER_HEARTBEAT_SERVELET =
"containerHeartbeat";
+ public static final String CLUSTERBASED_EXECUTION_ENVIRONMENT_CONTAINER_ID =
"executionContainerId";
+ public static final String CLUSTERBASED_COORDINATOR_URL =
"samza.autoscaling.server.url";
Review comment:
Let us leave the constants in the same file. I'd still suggest to remove
the `ClusterBased` prefix alone as its only yarn specific and not applicable to
a general cluster based deployments like K8s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
