mynameborat commented on a change in pull request #1445:
URL: https://github.com/apache/samza/pull/1445#discussion_r532992365
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/ContainerLaunchUtil.java
##########
@@ -151,10 +151,9 @@ private static void run(
if (new JobConfig(config).getJobCoordinatorHighAvailabilityEnabled()) {
ExecutionContainerIdManager executionContainerIdManager = new
ExecutionContainerIdManager(
- new NamespaceAwareCoordinatorStreamStore(coordinatorStreamStore,
SetExecutionContainerIdMapping.TYPE));
- if (executionContainerIdManager != null &&
execEnvContainerId.isPresent()) {
-
executionContainerIdManager.writeExecutionEnvironmentContainerIdMapping(containerId,
execEnvContainerId.get());
- }
+ new NamespaceAwareCoordinatorStreamStore(coordinatorStreamStore,
SetExecutionEnvContainerIdMapping.TYPE));
Review comment:
Can go inside the `ifPresent` block so that we don't create it unless it
is available? Why this is optional by the way? Seems like this is required and
we should bail out. unless its used in local flow where it isn't populated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
