dxichen commented on a change in pull request #1429:
URL: https://github.com/apache/samza/pull/1429#discussion_r540379609
##########
File path:
samza-api/src/main/java/org/apache/samza/checkpoint/StateCheckpointMarker.java
##########
@@ -17,21 +17,16 @@
* under the License.
*/
-package org.apache.samza.storage
+package org.apache.samza.checkpoint;
-import org.apache.samza.checkpoint.CheckpointId
-import org.apache.samza.system.SystemStreamPartition
+import org.apache.samza.storage.StateBackendFactory;
-trait TaskStorageManager {
- def getStore(storeName: String): Option[StorageEngine]
-
- def flush(): Map[SystemStreamPartition, Option[String]]
-
- def checkpoint(checkpointId: CheckpointId, newestChangelogOffsets:
Map[SystemStreamPartition, Option[String]]): Unit
-
- def removeOldCheckpoints(checkpointId: CheckpointId): Unit
-
- def stop(): Unit
+/**
+ * Interface for State Checkpoint Marker for all TaskStorageBackupManagers
+ */
+public interface StateCheckpointMarker {
+ String getFactoryName();
-}
\ No newline at end of file
+ StateBackendFactory getFactory();
Review comment:
You are correct, this could be inferred with the name, removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
