ZitingShen opened a new pull request #1457:
URL: https://github.com/apache/samza/pull/1457
### SAMZA-2563
Symptom: Calling InMemoryKeyValueStore.delete will double count the deletes
in metrics.
Cause: InMemoryKeyValueStore.delete is implemented by calling
InMemoryKeyValueStore.put with a null value. InMemoryKeyValueStore.delete
explicitly increments the delete metric. InMemoryKeyValueStore.put also
explicitly increments the delete metric when passed a null value.
Changes: Remove incrementing the delete metric in
InMemoryKeyValueStore.delete
Test: unit tests
### SAMZA-2618
Feature: Add a metric to measure the fraction of physical memory used out of
the total memory of the container. During autosizing, the container-count and
size can change as traffic changes, so only monitoring the phsical-memory-mb
does not provide enough information for alerting. We need a fraction or %
metric to allow for easy monitoring and alerting
Changes: Add a metric to measure the fraction of physical memory used out of
the total memory of the container.
Tests: unit tests & integration tests (TODO: check how to do integration
tests and verify this in debug log)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
