prateekm commented on a change in pull request #1463:
URL: https://github.com/apache/samza/pull/1463#discussion_r577255973
##########
File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java
##########
@@ -130,11 +183,19 @@
* Note: The message will be written but not flushed to the underlying
output system before its propagated to the
* chained operators. Messages retain the original partitioning scheme when
propogated to next operator.
*
+ * @param desc description of this send to operation
* @param outputStream the output stream to send messages to
* @return this {@link MessageStream}
*/
- MessageStream<M> sendTo(OutputStream<M> outputStream);
+ MessageStream<M> sendTo(String desc, OutputStream<M> outputStream);
+ /**
+ * Equivalent to {@code window("", window, id)}
+ * @see #window(String, Window, String)
+ */
+ default <K, WV> MessageStream<WindowPane<K, WV>> window(Window<M, K, WV>
window, String id) {
Review comment:
@kw2542 Do you think we can safely manage this backwards incompatible
change (e.g. choosing safer defaults, making it opt-in, providing migration
tooling etc.)? Would be better to manage a one time change than add a permanent
new API to work around it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
