mynameborat commented on a change in pull request #1467:
URL: https://github.com/apache/samza/pull/1467#discussion_r585992564
##########
File path: samza-shell/src/main/bash/run-class.sh
##########
@@ -154,9 +154,6 @@ fi
# Check if a max-heap size is specified. If not - set a 768M heap
[[ $JAVA_OPTS != *-Xmx* ]] && JAVA_OPTS="$JAVA_OPTS -Xmx768M"
-# Check if the GC related flags are specified. If not - add the respective
flags to JVM_OPTS.
-[[ $JAVA_OPTS != *PrintGCDateStamps* && $JAVA_OPTS != *-Xloggc* ]] &&
JAVA_OPTS="$JAVA_OPTS -XX:+PrintGCDateStamps -Xloggc:$SAMZA_LOG_DIR/gc.log"
Review comment:
Does default GC flag for `loggc` configured to generate `gc.log` in the
right directory?
##########
File path: samza-shell/src/main/bash/run-class.sh
##########
@@ -154,9 +154,6 @@ fi
# Check if a max-heap size is specified. If not - set a 768M heap
[[ $JAVA_OPTS != *-Xmx* ]] && JAVA_OPTS="$JAVA_OPTS -Xmx768M"
-# Check if the GC related flags are specified. If not - add the respective
flags to JVM_OPTS.
-[[ $JAVA_OPTS != *PrintGCDateStamps* && $JAVA_OPTS != *-Xloggc* ]] &&
JAVA_OPTS="$JAVA_OPTS -XX:+PrintGCDateStamps -Xloggc:$SAMZA_LOG_DIR/gc.log"
Review comment:
Does default GC flag for `-Xloggc` configured to generate `gc.log` in
the right directory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
