prateekm commented on a change in pull request #1429:
URL: https://github.com/apache/samza/pull/1429#discussion_r595449482
##########
File path:
samza-test/src/test/java/org/apache/samza/storage/kv/TransactionalStateIntegrationTest.java
##########
@@ -116,35 +116,53 @@ public void setUp() {
@Test
public void testStopAndRestart() {
List<String> inputMessagesOnInitialRun = Arrays.asList("1", "2", "3", "2",
"97", "-97", ":98", ":99", ":crash_once");
+ // double check collectors.flush
List<String> expectedChangelogMessagesOnInitialRun = Arrays.asList("1",
"2", "3", "2", "97", null, "98", "99");
initialRun(inputMessagesOnInitialRun,
expectedChangelogMessagesOnInitialRun);
- // first two are reverts for uncommitted messages from last run
- List<String> expectedChangelogMessagesOnSecondRun =
+ // first two are reverts for uncommitted messages from last run for keys
98 and 99
+ List<String> expectedChangelogMessagesAfterSecondRun =
Arrays.asList(null, null, "98", "99", "4", "5", "5");
List<String> expectedInitialStoreContentsOnSecondRun = Arrays.asList("1",
"2", "3");
secondRun(CHANGELOG_TOPIC,
- expectedChangelogMessagesOnSecondRun,
expectedInitialStoreContentsOnSecondRun);
+ expectedChangelogMessagesAfterSecondRun,
expectedInitialStoreContentsOnSecondRun, CONFIGS);
+ }
+
+ @Test
+ public void testStopAndRestartCheckpointV2() {
Review comment:
Since this is an unrelated scenario, can you extract this to a new class
(CheckpointVersionIntegrationTest?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
