lakshmi-manasa-g opened a new pull request #1480:
URL: https://github.com/apache/samza/pull/1480


   Symptom: setting yarn.am.container.label applies it to containers (other 
than AM) also. So no way to apply label only to AM.
   
   Cause: though yarn provides 3 modes of applying labels: only AM, only 
containers and all of job - samza uses am label and sets it for all of job.
   
   Fix: set am label only for AM in ClientHelper -- when creating request for 
yarn RM
   
   Tests: cant unit test due to nature of ClientHelper.
   
   Usage:  If yarn.am.container.label="label1" was being used to apply label1 
to whole of job -- now add 2 configs yarn.am.container.label="label1" and 
yarn.container.label="label1".
   
   Upgrade: backwards incompatible. to get same behavior as before - need 2 
configs in place of one now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to