Sanil15 commented on pull request #1475: URL: https://github.com/apache/samza/pull/1475#issuecomment-810532643
Took @bharathkk suggestion, we will let the BaseKeyValueStorageEngine hold the assumption for nonnull serdes, any custom KeyValueStorageEngineFactory that does not have this assumption right must not use BaseKeyValueStorageEngineFactory since the BaseKeyValueStorageEngineFactory#restore code needs this assumption, such use cases must directly use StorageEngineFactory with KeyValueStorageEngine with respective assumptions, ContainerStorageManager should also not hold any assumptions on serdes Closing this PR, will open a followup PR add more docs to BaseKeyValueStorageEngine and remove null serde redundant checks at CSM level -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
