kw2542 commented on a change in pull request #1487:
URL: https://github.com/apache/samza/pull/1487#discussion_r604442216



##########
File path: 
samza-core/src/main/java/org/apache/samza/runtime/ContainerLaunchUtil.java
##########
@@ -174,6 +174,8 @@ private static void run(
         log.error("Container stopped with Exception. Exiting process now.", 
containerRunnerException);
         System.exit(1);
       }
+    } catch (Throwable e) {
+      log.error("Container stopped with Exception. ", 
containerRunnerException);

Review comment:
       Do we need `System.exit(1)` like what `if (containerRunnerException != 
null)` do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to