cameronlee314 opened a new pull request #1494:
URL: https://github.com/apache/samza/pull/1494


   Issues: There is currently only one concrete `FaultDomainManager` 
implementation, and it is for YARN usage. It is also specified as the default 
in code. However, for non-YARN environments, we shouldn't include YARN 
dependencies, so we need another concrete implementation. For now, we can just 
add a very simple implementation as a placeholder.
   
   Changes: Added `SingleFaultDomainManager` which is a simple impl of 
`FaultDomainManager` which only has a single fault domain. This isn't wired in 
anywhere, but a job can configure it as the `FaultDomainManager` if desirable.
   
   Tests: Ran a simple test job on Kubernetes using this class (also excluded 
all code from `samza-yarn`). This won't work if standby containers are enabled, 
but it can still be a useful placeholder when standby containers are not needed.
   
   API changes and usage/upgrade instructions:
   Set the config `cluster-manager.fault-domain-manager.factory` to 
`org.apache.samza.clustermanager. SingleFaultDomainManagerFactory` to use this 
new fault domain manager.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to