cameronlee314 opened a new pull request #1499: URL: https://github.com/apache/samza/pull/1499
Issues: Currently, the port for the job coordinator url (for accessing job model) is always dynamically allocated. In some cases, it is helpful to be able to hardcode a port. Changes: When `JobModelManager` is setting up the `HttpServer` which serves the coordinator url, read a config to set the port. Tests: 1. `./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopassword` 2. Ran a job with `ProcessJobFactory` and verified the job started up. API changes: Set the config `cluster-manager.jobcoordinator.url.port` to the port number to use for the coordinator url. This is backwards compatible because the default is to use a value of 0 (to dynamically allocate an unused port), and a value of 0 was the value used before this change was made. More context about how this can be used: When using Kubernetes, ports only need to be unique within a pod, so port conflict issues are less likely when hardcoding ports. Being able to hardcode a port makes it easier to build the coordinator url since Kubernetes can also set up a "service name" for the coordinator instead of using the physical host name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
