dxichen commented on a change in pull request #1491:
URL: https://github.com/apache/samza/pull/1491#discussion_r631471543
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -245,8 +256,19 @@ public ContainerStorageManager(
containerChangelogSystems, systemFactories, config,
this.samzaContainerMetrics.registry());
this.storeConsumers = createStoreIndexedMap(this.changelogSystemStreams,
storeSystemConsumers);
+ // TODO HIGH dchen tune based on observed concurrency
+ JobConfig jobConfig = new JobConfig(config);
+ int restoreThreadPoolSize =
+ Math.min(
+ Math.max(containerModel.getTasks().size() * 2,
jobConfig.getRestoreThreadPoolSize()),
Review comment:
Fyi this is the temporary solution to resolve the potential deadlock (2x
task count)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
