prateekm commented on a change in pull request #1500:
URL: https://github.com/apache/samza/pull/1500#discussion_r631490013
##########
File path: docs/learn/documentation/versioned/jobs/configuration-table.html
##########
@@ -1911,6 +1911,22 @@ <h1>Samza Configuration Reference</h1>
</td>
</tr>
+ <tr>
+ <td class="property"
id="stores-rocksdb-max-open-files">stores.<span
class="store">store-name</span>.<br>rocksdb.max.open.files</td>
+ <td class="default">-1</td>
+ <td class="description">
+ Limits the number of open LOG files that RocksDB can
have open at one time.
Review comment:
Same for config below.
##########
File path: docs/learn/documentation/versioned/jobs/configuration-table.html
##########
@@ -1911,6 +1911,22 @@ <h1>Samza Configuration Reference</h1>
</td>
</tr>
+ <tr>
+ <td class="property"
id="stores-rocksdb-max-open-files">stores.<span
class="store">store-name</span>.<br>rocksdb.max.open.files</td>
+ <td class="default">-1</td>
+ <td class="description">
+ Limits the number of open LOG files that RocksDB can
have open at one time.
Review comment:
s/LOG files/files?
##########
File path:
samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbOptionsHelper.java
##########
@@ -109,6 +111,8 @@ public static Options options(Config storeConfig, int
numTasksForContainer, File
options.setMaxLogFileSize(storeConfig.getLong(ROCKSDB_MAX_LOG_FILE_SIZE_BYTES,
64 * 1024 * 1024L));
options.setKeepLogFileNum(storeConfig.getLong(ROCKSDB_KEEP_LOG_FILE_NUM,
2));
options.setDeleteObsoleteFilesPeriodMicros(storeConfig.getLong(ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_MICROS,
21600000000L));
+ options.setMaxOpenFiles(storeConfig.getInt(ROCKSDB_MAX_OPEN_FILES, -1));
+
options.setMaxOpenFiles(storeConfig.getInt(ROCKSDB_MAX_FILE_OPENING_THREADS,
16));
Review comment:
This is setting maxOpenFiles, typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
