prateekm commented on a change in pull request #1501:
URL: https://github.com/apache/samza/pull/1501#discussion_r636551779
##########
File path: samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
##########
@@ -66,6 +66,9 @@
public static final String CHANGELOG_MIN_COMPACTION_LAG_MS = STORE_PREFIX +
"%s.changelog." + MIN_COMPACTION_LAG_MS;
public static final long DEFAULT_CHANGELOG_MIN_COMPACTION_LAG_MS =
TimeUnit.HOURS.toMillis(4);
+ public static final String BLOB_STORE_BACKEND_ADMIN_FACTORY =
"blob.store.backend.admin.factory";
Review comment:
@shekhars-li Let's rename the configs / fields / accessors for
consistency too. E.g. maybe:
```stores.%s.backup.factories
stores.%s.restore.factories
blob.store.admin.factory
blob.store.manager.factory
getStoresWithBackupFactory()
getStoresWithRestoreFactory()
``` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
