cameronlee314 commented on pull request #1506: URL: https://github.com/apache/samza/pull/1506#issuecomment-871754032
IMO, if we decide to add side inputs to `TaskModel`, it should primarily be because we think it is useful as a user API (and I think it does make sense to add to `TaskModel` because side inputs are external I/O as well). It is just a bonus that it makes implementation of internal components easier. Would you prefer to wait for updating the `TaskModel` API in order to get the rest of these changes in? We still need the `InternalTaskContext` hack in order to pass `StreamMetadataCache` around anyways, even if `TaskModel` gets updated to have side inputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
