cameronlee314 opened a new pull request #1519: URL: https://github.com/apache/samza/pull/1519
Issues: 1. With some new coordination changes coming in a future PR, the current granularity of checkMetadataChanges is insufficient. The new logic needs to know what kind of metadata changes occurred, not just if there was a change or not. 2. Epoch id fetching is currently YARN-specific. This will not work for non-YARN use cases. Changes: 1. Modify `checkForMetadataChanges` to return a set of changes instead of a boolean. 2. Modify `fetchEpochIdForJobCoordinator` to read epoch id out of a generic environment variable instead of parsing it out of a YARN-specific variable. 3. Move `JobCoordinatorMetadataManager` to a new package because `org.apache.samza.coordinator` is bloated. Tests: Updated unit tests for `JobCoordinatorMetadataManager` and ran `./gradlew build`. API changes: For non-YARN usage of `JobCoordinatorMetadataManager`, pass the epoch id through the `SAMZA_EPOCH_ID` environment variable. There are currently no non-YARN usage, but there will be one coming in the near future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
