alnzng commented on pull request #1515: URL: https://github.com/apache/samza/pull/1515#issuecomment-900614120
> Thanks for refactoring the codes and adding more test cases, the code changes look good to me. > > One thing you may want to double check is that I saw OOM happened when running the command locally: `./gradlew build -PrunIntegrationTests`: > > ``` > > Task :samza-core_2.11:test > > Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "RMI RenewClean-[alazhang-mn1.linkedin.biz:56375]" > > Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "RMI RenewClean-[alazhang-mn1.linkedin.biz:56656]" > > Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Thread-156" > > executionError FAILED > java.lang.OutOfMemoryError: Java heap space > > 1446 tests completed, 1 failed, 4 skipped > > > Task :samza-core_2.11:test FAILED > > FAILURE: Build failed with an exception. > ``` Tried to rebuild on the existing project and also tried to fresh checkout, the build passed on both of them, I didn't see this OOM problem anymore. Also @cameronlee314 tried on his local env and he didn't observe any problem. For now, I would think it is an unreproducible problem, it could be caused by some noise in my local env. The problem should not be caused by these code changes. So, this PR looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
