cameronlee314 commented on a change in pull request #1520: URL: https://github.com/apache/samza/pull/1520#discussion_r698680590
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitorFactory.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.coordinator; + +import java.util.Set; +import org.apache.samza.SamzaException; +import org.apache.samza.config.Config; +import org.apache.samza.config.JobConfig; +import org.apache.samza.config.TaskConfig; +import org.apache.samza.metrics.MetricsRegistry; +import org.apache.samza.system.StreamMetadataCache; +import org.apache.samza.system.SystemStream; + + +/** + * Common place for reading configs and wiring {@link StreamPartitionCountMonitor}. + */ +public class StreamPartitionCountMonitorFactory { + private final StreamMetadataCache streamMetadataCache; + private final MetricsRegistry metrics; + + public StreamPartitionCountMonitorFactory(StreamMetadataCache streamMetadataCache, MetricsRegistry metrics) { + this.streamMetadataCache = streamMetadataCache; + this.metrics = metrics; + } + + /** + * Build {@link StreamPartitionCountMonitor} for input streams. + */ + public StreamPartitionCountMonitor buildInputStreamPartitionCountMonitor(Config config, Review comment: Ok, I do prefer the conciseness as well, so I will change it back. If we do need differentiation in the future, we can just change the method name. I suppose it won't hurt to use the name `finalConfig` to help be a little more explicit, but I still don't think the stage of the config should be part of the contract between classes (unless they the classes are directly dealing with config rewriting), because that introduces an ordering dependency. Most classes should be written in a way that is agnostic to where they are being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
