cameronlee314 commented on pull request #1532: URL: https://github.com/apache/samza/pull/1532#issuecomment-925353151
> also for - " logs that happen before the call to LoggingContextHolder.INSTANCE.setConfig in ContainerLaunchUtil will no longer be handled by StreamAppender. There are few logs that are impacted by this." > are there logs generated within samza that will be not sent to StreamAppender? Yes, `LocalContainerRunner` has a couple logs that would be missed by `StreamAppender`. Also, if there is an external caller of `ContainerLaunchUtil.run` (e.g. Beam), then any logs from that external caller which happen before `ContainerLaunchUtil.run` is called will be missed. For `LocalContainerRunner`, I can move those logs to be after `ContainerLaunchUtil.run`. For external callers, they can call `LoggingContextHolder.INSTANCE.setConfig` explicitly if they need logging to be available sooner. I will update this in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
