cameronlee314 commented on a change in pull request #1529: URL: https://github.com/apache/samza/pull/1529#discussion_r715196019
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/NoProcessorJobCoordinatorListener.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.coordinator; + +import java.util.concurrent.CountDownLatch; +import org.apache.samza.job.model.JobModel; + + +/** + * {@link JobCoordinatorListener} for a {@link JobCoordinator} which does not run alongside a processor. + */ +public class NoProcessorJobCoordinatorListener implements JobCoordinatorListener { + private final CountDownLatch waitForShutdownLatch; + + public NoProcessorJobCoordinatorListener(CountDownLatch waitForShutdownLatch) { + this.waitForShutdownLatch = waitForShutdownLatch; + } + + @Override + public void onJobModelExpired() { + // nothing to do + } + + @Override + public void onNewJobModel(String processorId, JobModel jobModel) { + // nothing to do + } + + @Override + public void onCoordinatorStop() { + this.waitForShutdownLatch.countDown(); + } + + @Override + public void onCoordinatorFailure(Throwable t) { + this.waitForShutdownLatch.countDown(); Review comment: There isn't currently anywhere to bubble this up to, but good suggestion about logging. If there is a use case for bubbling up in the future, we can add it in at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
