ZitingShen commented on a change in pull request #1542:
URL: https://github.com/apache/samza/pull/1542#discussion_r721582950
##########
File path:
samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobOutputStream.java
##########
@@ -322,33 +321,20 @@ private synchronized void uploadBlockAsync() {
// call async stageblock and add to future
@Override
public void run() {
- int attemptCount = 0;
byte[] compressedLocalByte = compression.compress(localByte);
int blockSize = compressedLocalByte.length;
- while (attemptCount < MAX_ATTEMPT) {
- try {
- ByteBuffer outputStream = ByteBuffer.wrap(compressedLocalByte, 0,
blockSize);
- metrics.updateCompressByteMetrics(blockSize);
- LOG.info("{} Upload block start for blob: {} for block size:{}.",
blobAsyncClient.getBlobUrl().toString(), blockId, blockSize);
- metrics.updateAzureUploadMetrics();
- // StageBlock generates exception on Failure.
- stageBlock(blockIdEncoded, outputStream, blockSize);
- break;
- } catch (InterruptedException e) {
Review comment:
Does it mean InterruptedException is not thrown during sending request?
Otherwise you probably need to change the retry policy to make retry not stuck
on InterruptedException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
