cameronlee314 opened a new pull request #1559: URL: https://github.com/apache/samza/pull/1559
Issue: `TestContainerAllocatorWithHostAffinity.testExpiredRequestAllocationOnAnyHost` transiently fails. The test comments say it should check for "at least 2" cancelled resource requests and "at least 2" `ANY_HOST` requests, but the actual logic checks for "greater than 2". Usually, the test passes, because the 2 preferred host requests get cancelled, and then there is time for the follow up `ANY_HOST` request to also get cancelled. The comments in this test seem to indicate that it is not the intention to check on the follow up `ANY_HOST` requests, but the validation logic relied on the follow up `ANY_HOST` expirations. In https://github.com/apache/samza/pull/1556, the test was updated to wait 1000ms with an expiration timeout of 500ms, so this barely left enough time for the follow-up `ANY_HOST` expiration. Changes: Updated the test to wait longer so the follow-up `ANY_HOST` expirations can happen, and explicitly check for `ANY_HOST` expirations (also updated comments to reflect the explicit check). Tests: Unit test passes API changes: N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
